Messages in this thread | | | Date | Sun, 2 Dec 2018 12:29:00 +0000 | From | Marc Zyngier <> | Subject | Re: [PATCH 1/2] irq/irq_sim: provide irq_sim_fire_edge() |
| |
On Fri, 30 Nov 2018 23:26:25 +0100 Linus Walleij <linus.walleij@linaro.org> wrote:
> On Thu, Nov 29, 2018 at 7:14 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > > Thomas, Linus: after commit fa38869b0161 ("gpiolib: Don't support irq > > sharing for userspace") some libgpiod tests are failing because we can > > no longer depend on reading the value of a dummy GPIO after detecting > > an interrupt to know the edge of the interrupt. While these interrupts > > are triggered from debugfs and debugfs is not required to maintain > > compatibility, I thing having a working test suite for the GPIO > > subsystem and uAPI is worth applying these two patches and also the > > previous one[1]. > > > > Can we have them applied for 4.20 or are there any objections? > > I'm fine with applying them if I can just get an ACK from one of the IRQ > maintainers (Thomas, Marc).
I'm fine with that patch, with the provision that (nitpick) the edge field is turned into a bool instead of an int.
With that,
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Thanks,
M. -- Without deviation from the norm, progress is not possible.
| |