Messages in this thread | | | Subject | Re: [PATCH RESEND] KEYS: fix parsing invalid pkey info string | From | Mimi Zohar <> | Date | Mon, 17 Dec 2018 15:29:18 -0500 |
| |
On Mon, 2018-12-17 at 12:02 -0800, Linus Torvalds wrote: > Talking about the conflicting ones: Opt_hash checks that > Opt_policydigest isn't set. But Opt_policydigest doesn't check that > Opt_hash isn't set, so you can mix the two if you just do it in the > right order. > > But that's a separate bug, and doesn't seem to be a huge deal. > > But it *is* an example of how bogus all of this stuff is. Clearly > people weren't really paying attention when writing any of this code.
A file signature is more restrictive than just a file hash. I'll clean up this and the other ugliness.
Mimi
| |