Messages in this thread | | | Date | Mon, 17 Dec 2018 21:37:58 +0200 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH v17 18/23] platform/x86: Intel SGX driver |
| |
On Mon, Dec 17, 2018 at 11:09:33AM -0800, Dave Hansen wrote: > On 12/17/18 10:48 AM, Sean Christopherson wrote: > > We can't set mm to NULL as we need it to unregister the notifier, and > > I'm fairly certain attempting to unregister in the release callback > > will deadlock. > > Suggestion: > > It looks like you only expect one VMA per enclave. Things go bonkers if > this is not true. So, instead of storing encl->mm, don't. You can get > the mm from vma->vm_mm and you could just store encl->vma instead.
The code actually supports having multiple VMAs per enclave.
/Jarkko
| |