Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 17 Dec 2018 19:48:00 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH v14 1/5] x86/boot: Introduce get_acpi_rsdp() to parse RSDP in cmdline from KEXEC |
| |
* Thomas Gleixner <tglx@linutronix.de> wrote:
> On Mon, 17 Dec 2018, Ingo Molnar wrote: > > * Chao Fan <fanc.fnst@cn.fujitsu.com> wrote: > > > + val[len] = '\0'; > > > + return (acpi_physical_address)simple_strtoull(val, &e, 16); > > > > 'return' is not a function - no need for the parenthesis. > > It's a typecast which better has parenthesis....
Yeah, see my followup to the other reply where I withdraw the objection and point out the ugliness of the various typecasts.
Thanks,
Ingo
| ![\](/images/icornerr.gif) |