lkml.org 
[lkml]   [2018]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v14 1/5] x86/boot: Introduce get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

* Thomas Gleixner <tglx@linutronix.de> wrote:

> On Mon, 17 Dec 2018, Ingo Molnar wrote:
> > * Chao Fan <fanc.fnst@cn.fujitsu.com> wrote:
> > > + val[len] = '\0';
> > > + return (acpi_physical_address)simple_strtoull(val, &e, 16);
> >
> > 'return' is not a function - no need for the parenthesis.
>
> It's a typecast which better has parenthesis....

Yeah, see my followup to the other reply where I withdraw the objection
and point out the ugliness of the various typecasts.

Thanks,

Ingo

\
 
 \ /
  Last update: 2018-12-17 19:48    [W:0.106 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site