Messages in this thread | | | Date | Mon, 17 Dec 2018 20:23:19 +0200 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH v17 18/23] platform/x86: Intel SGX driver |
| |
On Mon, Dec 17, 2018 at 10:09:57AM -0800, Sean Christopherson wrote: > No, EREMOVE should never fail if the enclave is being released, i.e. all > references to the enclave are gone. And failure during sgx_encl_release() > means we leaked an EPC page, which warrants a WARN.
Right that what I was suspecting as swapper should hold a ref to the enclave while it is working on it. It is a programming error when this happens.
Maybe change the boolean parameter to flags parameter have a flag to use sgx_free_page()?
> That makes sense.
What do you think of Dave's proposal?
/Jarkko
| |