lkml.org 
[lkml]   [2018]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: WARNING in __rcu_read_unlock
On Mon, 17 Dec 2018 16:24:21 +0100
Stefano Brivio <sbrivio@redhat.com> wrote:

> On Mon, 17 Dec 2018 06:57:35 -0800
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
> > Might be cause by commit b8a51b38e4d4dec3e379d52c0fe1a66827f7cf1e
> > fou, fou6: ICMP error handlers for FoU and GUE
>
> This:
>
> diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c
> index 0d0ad19ecb87..20a6de26d146 100644
> --- a/net/ipv4/fou.c
> +++ b/net/ipv4/fou.c
> @@ -1008,6 +1008,9 @@ static int gue_err_proto_handler(int proto, struct sk_buff *skb, u32 info)
> {
> const struct net_protocol *ipprot = rcu_dereference(inet_protos[proto]);
>
> + if (ipprot == IPPROTO_UDP)
^^^ proto, of course

> + return -EINVAL;
> +
> if (ipprot && ipprot->err_handler) {
> if (!ipprot->err_handler(skb, info))
> return 0;
>

--
Stefano

\
 
 \ /
  Last update: 2018-12-17 19:22    [W:0.099 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site