lkml.org 
[lkml]   [2018]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v17 18/23] platform/x86: Intel SGX driver
From
Date
On 12/17/18 10:01 AM, Jarkko Sakkinen wrote:
>>> + encl->mm = current->mm; <---------------------------------> + encl->base = secs->base;
>>> + encl->size = secs->size;
>>> + encl->ssaframesize = secs->ssa_frame_size;
>>> + encl->backing = backing;
>>> +
>>> + return encl;
>>> +}
>> How is this OK without taking a reference on the mm?
>>
>> I have a feeling a bunch of your bugs with the mmu notifiers and so
>> forth are because the refcounting is wrong here.
>>
>> Sean's SGX_ENCL_MM_RELEASED would, I think be unnecessary if you just
>> take a refcount here and release it when the enclave is destroyed.
> Right, atomic_inc(encl->mm->count) here and once when releasing.
>
> The we would not even need the whole mmu notifier in the first place.

Please use mmget()/mmput().

\
 
 \ /
  Last update: 2018-12-17 19:07    [W:0.267 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site