Messages in this thread | | | Date | Mon, 17 Dec 2018 16:45:51 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v13 1/6] x86/boot: Introduce kstrtoull() to boot directory instead of simple_strtoull() |
| |
On Mon, Dec 17, 2018 at 09:27:28AM +0800, Chao Fan wrote: > Oops, I thought you agree with what Baoquan said, so I send the new version > and use simple_strtoull() back.
I could've misunderstood him. Lemme repeat what I mean:
- we should make kstrtoull() work because it is the right function to use. Which means, include this too:
https://lkml.kernel.org/r/20181216203113.GA23823@zn.tnic
- we should gradually start replacing simple_strtoull() in arch/x86/boot/ and eventually get rid of it. But that's for the TODO list, to take care of later.
- Take our time and stop with the hurrying and do the whole thing nice and clean.
Ok?
Or have I forgotten something?
If not, I'll continue looking at your v13.
Thx.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |