lkml.org 
[lkml]   [2018]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging:iio:adc: fix codestyle
The patch prefix should be "staging: iio: adc: ad7280a:".  Do
git log --oneline drivers/staging/iio/adc/ad7280a.c and copy what
other people do.

On Mon, Dec 17, 2018 at 04:43:33AM +0300, Sergey Efimochkin wrote:
> staging:iio:adc: fix codestyle

Only to do one thing per patch. We need a better patch description.

> Signed-off-by: Sergey Efimochkin <efimochkin.sv@phystech.edu>
> ---
> drivers/staging/iio/adc/ad7280a.c | 20 +++++++++-----------
> 1 file changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> index 58420dcb406d..52e12d1201b3 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -706,8 +706,8 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
> st->cell_threshhigh)
> iio_push_event(indio_dev,
> IIO_EVENT_CODE(IIO_VOLTAGE,
> - 1,
> - 0,
> + 1,
> + 0,
> IIO_EV_DIR_RISING,
> IIO_EV_TYPE_THRESH,
> 0, 0, 0),

No. Now the IIO_EV_DIR_RISING, and later columns are not aligned
correctly. Just ignore the checkpatch warning. It's fine as-is.

> @@ -987,6 +985,6 @@ static struct spi_driver ad7280_driver = {
> };
> module_spi_driver(ad7280_driver);
>
> -MODULE_AUTHOR("Michael Hennerich <michael.hennerich@analog.com>");
> +MODULE_AUTHOR("Michael Hennerich <hennerich@blackfin.uclinux.org>");

This change needs to come from Michael. Just leave the code as-is.

regards,
dan carpenter

\
 
 \ /
  Last update: 2018-12-17 08:47    [W:0.041 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site