lkml.org 
[lkml]   [2018]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 03/19] mailbox: bcm2835: Use device-managed registration API
    Date
    From: Thierry Reding <treding@nvidia.com>

    Get rid of some boilerplate driver removal code by using the newly added
    device-managed registration API.

    Cc: Eric Anholt <eric@anholt.net>
    Cc: Stefan Wahren <stefan.wahren@i2se.com>
    Signed-off-by: Thierry Reding <treding@nvidia.com>
    ---
    drivers/mailbox/bcm2835-mailbox.c | 10 +---------
    1 file changed, 1 insertion(+), 9 deletions(-)

    diff --git a/drivers/mailbox/bcm2835-mailbox.c b/drivers/mailbox/bcm2835-mailbox.c
    index bb3ee728169d..39761d190545 100644
    --- a/drivers/mailbox/bcm2835-mailbox.c
    +++ b/drivers/mailbox/bcm2835-mailbox.c
    @@ -172,7 +172,7 @@ static int bcm2835_mbox_probe(struct platform_device *pdev)
    if (!mbox->controller.chans)
    return -ENOMEM;

    - ret = mbox_controller_register(&mbox->controller);
    + ret = devm_mbox_controller_register(dev, &mbox->controller);
    if (ret)
    return ret;

    @@ -182,13 +182,6 @@ static int bcm2835_mbox_probe(struct platform_device *pdev)
    return ret;
    }

    -static int bcm2835_mbox_remove(struct platform_device *pdev)
    -{
    - struct bcm2835_mbox *mbox = platform_get_drvdata(pdev);
    - mbox_controller_unregister(&mbox->controller);
    - return 0;
    -}
    -
    static const struct of_device_id bcm2835_mbox_of_match[] = {
    { .compatible = "brcm,bcm2835-mbox", },
    {},
    @@ -201,7 +194,6 @@ static struct platform_driver bcm2835_mbox_driver = {
    .of_match_table = bcm2835_mbox_of_match,
    },
    .probe = bcm2835_mbox_probe,
    - .remove = bcm2835_mbox_remove,
    };
    module_platform_driver(bcm2835_mbox_driver);

    --
    2.19.1
    \
     
     \ /
      Last update: 2018-12-17 16:04    [W:2.737 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site