Messages in this thread | | | Subject | Re: [PATCH net-next] net: bridge: remove unneeded variable 'err' | From | Nikolay Aleksandrov <> | Date | Mon, 17 Dec 2018 13:21:08 +0200 |
| |
On 17/12/2018 13:16, YueHaibing wrote: > On 2018/12/17 17:51, Nikolay Aleksandrov wrote: >> On 17/12/2018 11:46, YueHaibing wrote: >>> function br_multicast_toggle now always return 0, >>> so the variable 'err' is unneeded. >>> Also cleanup dead branch in br_changelink. >>> >>> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >>> --- >>> net/bridge/br_multicast.c | 3 +-- >>> net/bridge/br_netlink.c | 4 +--- >>> 2 files changed, 2 insertions(+), 5 deletions(-) >>> >> >> That is correct, but in such case just make it void. > > In net/bridge/br_sysfs_br.c: > > static ssize_t multicast_snooping_store(struct device *d, > struct device_attribute *attr, > const char *buf, size_t len) > { > return store_bridge_parm(d, buf, len, br_multicast_toggle); > } > > and store_bridge_parm need the returned err. >
That can be worked-around with a set option that returns 0 but it's not that important.
Fair enough, Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
| |