lkml.org 
[lkml]   [2018]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 14/51] sysv: return err instead of 0 in __sysv_write_inode
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit c4b7d1ba7d263b74bb72e9325262a67139605cde ]

    Fixes gcc '-Wunused-but-set-variable' warning:

    fs/sysv/inode.c: In function '__sysv_write_inode':
    fs/sysv/inode.c:239:6: warning:
    variable 'err' set but not used [-Wunused-but-set-variable]

    __sysv_write_inode should return 'err' instead of 0

    Fixes: 05459ca81ac3 ("repair sysv_write_inode(), switch sysv to simple_fsync()")
    Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/sysv/inode.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/sysv/inode.c b/fs/sysv/inode.c
    index d62c423a5a2d..7b391b43bcf5 100644
    --- a/fs/sysv/inode.c
    +++ b/fs/sysv/inode.c
    @@ -275,7 +275,7 @@ static int __sysv_write_inode(struct inode *inode, int wait)
    }
    }
    brelse(bh);
    - return 0;
    + return err;
    }

    int sysv_write_inode(struct inode *inode, struct writeback_control *wbc)
    --
    2.19.1


    \
     
     \ /
      Last update: 2018-12-14 13:25    [W:7.223 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site