lkml.org 
[lkml]   [2018]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 08/12] clk: mediatek: Add MT8183 clock support
From
Date
Quoting Weiyi Lu (2018-12-09 23:32:36)
> + "apll2_ck"
> +};
> +
> +static const struct mtk_mux top_muxes[] = {
> + /* CLK_CFG_0 */
> + MUX_GATE_CLR_SET_UPD_FLAGS(CLK_TOP_MUX_AXI, "axi_sel",
> + axi_parents, 0x40,
> + 0x44, 0x48, 0, 2, 7, 0x004, 0, CLK_IS_CRITICAL),

Please document why CLK_IS_CRITICAL is being used everywhere it's used.

> + MUX_GATE_CLR_SET_UPD(CLK_TOP_MUX_MM, "mm_sel",
> + mm_parents, 0x40,
> + 0x44, 0x48, 8, 3, 15, 0x004, 1),
> + MUX_GATE_CLR_SET_UPD(CLK_TOP_MUX_IMG, "img_sel",
> + img_parents, 0x40,
> + 0x44, 0x48, 16, 3, 23, 0x004, 2),
> + MUX_GATE_CLR_SET_UPD(CLK_TOP_MUX_CAM, "cam_sel",

\
 
 \ /
  Last update: 2018-12-14 23:01    [W:0.091 / U:2.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site