lkml.org 
[lkml]   [2018]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH][next] nvmet: fix comparison of a u16 with -1
    Date
    From: Colin Ian King <colin.king@canonical.com>

    Currently the u16 req->error_loc is being compared to -1 which
    will always be false. Fix this by casting -1 to u16 to fix this.

    Detected by clang:
    warning: result of comparison of constant -1 with expression of
    type 'u16' (aka 'unsigned short') is always false
    [-Wtautological-constant-out-of-range-compare]

    Fixes: 76574f37bf4c ("nvmet: add interface to update error-log page")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    ---
    drivers/nvme/target/core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
    index cc81d0231587..b9c219c931eb 100644
    --- a/drivers/nvme/target/core.c
    +++ b/drivers/nvme/target/core.c
    @@ -663,7 +663,7 @@ static void nvmet_set_error(struct nvmet_req *req, u16 status)

    req->rsp->status = cpu_to_le16(status << 1);

    - if (!ctrl || req->error_loc == -1)
    + if (!ctrl || req->error_loc == (u16)-1)
    return;

    spin_lock_irqsave(&ctrl->error_lock, flags);
    --
    2.19.1
    \
     
     \ /
      Last update: 2018-12-14 19:32    [W:6.070 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site