Messages in this thread | | | Subject | Re: [PATCH v2 2/3] spi: meson-axg: enhance output enable feature | From | Sunny Luo <> | Date | Thu, 13 Dec 2018 21:31:13 +0800 |
| |
Hi Jerome,
On 2018/12/13 17:04, Jerome Brunet wrote: > On Thu, 2018-12-13 at 16:39 +0800, Sunny Luo wrote: >> The SPICC controller in Meson-AXG is capable of driving the CLK/MOSI/SS >> signal lines through the idle state (between two transmission operation), >> which avoid the signals floating in unexpected state. >>
>> @@ -453,6 +474,8 @@ static int meson_spicc_prepare_message(struct spi_master >> *master, >> >> writel_bits_relaxed(BIT(24), BIT(24), spicc->base + SPICC_TESTREG); >> >> + meson_spicc_oen_enable(spicc); >> + > > Any specific reason for doing this in prepare_message() ? It looks like > something that could/should be done during the probe
Yes, as replied in Mark's mail, i will move it into probe next patch.
| |