Messages in this thread | ![/](/images/icornerl.gif) | | From | Sergey Senozhatsky <> | Date | Thu, 13 Dec 2018 21:42:55 +0900 | Subject | Re: [PATCH] printk: Add caller information to printk() output. |
| |
On (12/13/18 13:18), Petr Mladek wrote: > > Sometimes we want to print a series of printk() messages to consoles > > without being disturbed by concurrent printk() from interrupts and/or > > other threads. But we can't enforce printk() callers to use their local > > buffers because we need to ask them to make too much changes. Also, even > > buffering up to one line inside printk() might cause failing to emit > > an important clue under critical situation. > > > > Therefore, instead of trying to help buffering, let's try to help > > reconstructing messages by saving caller information as of calling > > log_store() and adding it as "[T$thread_id]" or "[C$processor_id]" > > upon printing to consoles. > > > > Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> > > The patch looks fine to me: > > Reviewed-by: Petr Mladek <pmladek@suse.com> > > Sergey, would you mind to ack this patch as well?
Sure, Petr
Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> From my point of view, the patch is ready to go into > linux-next. Well, I would prefer to keep it there one more > release cycle.
No objections.
-ss
| ![\](/images/icornerr.gif) |