Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH 2/2] fat: New macros to determine the FAT variant (32, 16 or 12) | Date | Fri, 14 Dec 2018 12:16:07 +0900 |
| |
Joe Perches <joe@perches.com> writes:
>> >> -#define FAT_FIRST_ENT(s, x) ((MSDOS_SB(s)->fat_bits == 32 ? 0x0FFFFF00 : \ >> - MSDOS_SB(s)->fat_bits == 16 ? 0xFF00 : 0xF00) | (x)) >> +#define IS_FAT12(sbi) (sbi->fat_bits == 12) >> +#define IS_FAT16(sbi) (sbi->fat_bits == 16) >> +#define IS_FAT32(sbi) (sbi->fat_bits == 32) > > sbi should be parenthesized or perhaps better these should be > static inline bool functions
Right, rather this is the bug (not hit yet though) that should be fixed.
Thanks. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |