lkml.org 
[lkml]   [2018]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'
    Date
    Hi Firoz,

    On Wed, Dec 12, 2018 at 10:04:47AM +0530, Firoz Khan wrote:
    > > > Will this below change will help?
    > > >
    > > > #define _MIPS_SIM_ABI32 1
    > > > #define _MIPS_SIM_NABI32 2
    > > > #define _MIPS_SIM_ABI64 3
    > > > +#define _MIPS_SIM_ABIN64 _MIPS_SIM_ABI64
    > >
    > > Hmm, I think I'd prefer that we just keep using _MIPS_SIM_ABI64.
    >
    > Sure, I think '64' to 'n64' conversion must be remove it from this patch
    > series.I can send v5 without '64' to 'n64' conversion.
    >
    > If we rename '64' to 'n64' in half of the place and this _MIPS_SIM_ABI64
    > if we half to keep it in same looks not good (according to me).
    >
    > (FYI, This macro name - _MIPS_SIM_ABIN64 must be _MIPS_SIM_NABI64
    > and defintion will be:
    > +#define _MIPS_SIM_NABI64 _MIPS_SIM_ABI64)
    >
    > So If you confirm I can send v5 without '64' to 'n64' conversion (not just above
    > one, completely from this patch series). Or uou can take a call just
    > keep this macro -
    > _MIPS_SIM_ABI64 as it is and change it rest of the place.

    Let's just go ahead & leave everything as 64, and I'll do the 64 -> n64
    rename later. I hoped whilst you were adding n64-specific code this
    would be an easy change, but at this point let's just prioritize getting
    the series applied without the naming change so it can sit in -next for
    a while before the merge window.

    Thanks,
    Paul

    \
     
     \ /
      Last update: 2018-12-12 23:28    [W:6.436 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site