Messages in this thread | | | Date | Wed, 12 Dec 2018 11:06:12 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH 7/7] selftest/bpf: fix E501 line too long |
| |
On Wed, 12 Dec 2018 11:24:02 +0100, Daniel Borkmann wrote: > > - raise Exception("Time out waiting for program counts to stabilize want %d/%d, have %d bound, %d loaded" % ( > > + raise Exception("Time out waiting for program counts to \ > > +stabilize want %d/%d, have %d bound, %d loaded" % ( > > bound, total, nbound, nprogs)) > > I'll leave the test_offload.py ones up to Jakub, but to me it seems > this particular change here would actually make the code look worse > and harder to grep for error messages, so my preference would be to > at least leave the error messages as-is. Also seems it's not a 'must' > in pep8 [0]. > > [0] https://www.python.org/dev/peps/pep-0008/#maximum-line-length
Thanks, agreed, this has been run through checkpatch, so the line lengths should be fine (and we don't want error messages split).
| |