lkml.org 
[lkml]   [2018]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 5/5] regulator: add documentation for regulator modes and suspend states
    On Wed, Dec 12, 2018 at 3:13 AM <Claudiu.Beznea@microchip.com> wrote:
    >
    >
    >
    > On 12.12.2018 00:13, Rob Herring wrote:
    > > On Tue, Nov 27, 2018 at 11:57:25AM +0000, Claudiu.Beznea@microchip.com wrote:
    > >> From: Claudiu Beznea <claudiu.beznea@microchip.com>
    > >>
    > >> Add documentation for regulator modes and suspend states.
    > >>
    > >> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
    > >> ---
    > >> .../bindings/regulator/act8945a-regulator.txt | 34 ++++++++++++++++++++++
    > >> 1 file changed, 34 insertions(+)
    > >>
    > >> diff --git a/Documentation/devicetree/bindings/regulator/act8945a-regulator.txt b/Documentation/devicetree/bindings/regulator/act8945a-regulator.txt
    > >> index ac955dea00d1..4017527619ab 100644
    > >> --- a/Documentation/devicetree/bindings/regulator/act8945a-regulator.txt
    > >> +++ b/Documentation/devicetree/bindings/regulator/act8945a-regulator.txt
    > >> @@ -15,11 +15,17 @@ Optional input supply properties:
    > >> - inl67-supply: The input supply for REG_LDO3 and REG_LDO4
    > >>
    > >> Any standard regulator properties can be used to configure the single regulator.
    > >> +regulator-initial-mode, regulator-allowed-modes and regulator-mode could be
    > >> +specified using mode values from dt-bindings/regulator/active-semi,8945a-regulator.h
    > >> +file.
    > >>
    > >> The valid names for regulators are:
    > >> REG_DCDC1, REG_DCDC2, REG_DCDC3, REG_LDO1, REG_LDO2, REG_LDO3, REG_LDO4.
    > >>
    > >> Example:
    > >> +
    > >> +#include <dt-bindings/regulator/active-semi,8945a-regulator.h>
    > >
    > > This file belongs in this patch.
    >
    > I'm using the defines in this file also in driver. I was thinking that if I
    > would include this file in this patch the driver compilation would fail if
    > the patches would be accepted via different trees.

    They won't be.

    > Would you like me to have different defines in driver and this new header
    > or could happen that these patches to be included in the main tree via the
    > same tree (e.g. regulator tree)?

    No need for different defines. The subsystem maintainer will take
    everything in this case.

    Rob

    \
     
     \ /
      Last update: 2018-12-12 14:33    [W:2.942 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site