lkml.org 
[lkml]   [2018]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 67/67] mac80211: ignore NullFunc frames in the duplicate detection
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

    commit 990d71846a0b7281bd933c34d734e6afc7408e7e upstream.

    NullFunc packets should never be duplicate just like
    QoS-NullFunc packets.

    We saw a client that enters / exits power save with
    NullFunc frames (and not with QoS-NullFunc) despite the
    fact that the association supports HT.
    This specific client also re-uses a non-zero sequence number
    for different NullFunc frames.
    At some point, the client had to send a retransmission of
    the NullFunc frame and we dropped it, leading to a
    misalignment in the power save state.
    Fix this by never consider a NullFunc frame as duplicate,
    just like we do for QoS NullFunc frames.

    This fixes https://bugzilla.kernel.org/show_bug.cgi?id=201449

    CC: <stable@vger.kernel.org>
    Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    net/mac80211/rx.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/mac80211/rx.c
    +++ b/net/mac80211/rx.c
    @@ -1254,6 +1254,7 @@ ieee80211_rx_h_check_dup(struct ieee8021
    return RX_CONTINUE;

    if (ieee80211_is_ctl(hdr->frame_control) ||
    + ieee80211_is_nullfunc(hdr->frame_control) ||
    ieee80211_is_qos_nullfunc(hdr->frame_control) ||
    is_multicast_ether_addr(hdr->addr1))
    return RX_CONTINUE;

    \
     
     \ /
      Last update: 2018-12-11 17:08    [W:6.654 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site