lkml.org 
[lkml]   [2018]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] host1x: cdma: use completion instead of semaphore
On Tue, Dec 11, 2018 at 11:11:38AM +0100, Arnd Bergmann wrote:
> On Tue, Dec 11, 2018 at 11:08 AM Thierry Reding
> <thierry.reding@gmail.com> wrote:
> >
> > On Mon, Dec 10, 2018 at 10:51:04PM +0100, Arnd Bergmann wrote:
> > > In this usage, the two are completely equivalent, but the
> > > completion documents better what is going on, and we generally
> > > try to avoid semaphores these days.
> > >
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > ---
> > > drivers/gpu/host1x/cdma.c | 6 +++---
> > > drivers/gpu/host1x/cdma.h | 4 ++--
> > > 2 files changed, 5 insertions(+), 5 deletions(-)
> >
> > My understanding is that potentially many userspace processes could be
> > blocking on this, which I think is the reason for it being a semaphore.
> > Is the completion going to work for those cases as well?
>
> Yes, it behaves the exact same way here.

Great, I'll queue this for v4.22.

Thanks,
Thierry
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-12-11 11:27    [W:0.288 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site