lkml.org 
[lkml]   [2018]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] mm/mmu_notifier: fix mmu_notifier_range_init warning
On Tue, Dec 11, 2018 at 10:43 PM David Rientjes <rientjes@google.com> wrote:
>
> On Tue, 11 Dec 2018, Jerome Glisse wrote:

>
> Hmm, strange that Arnd's build failure is only reporting about an unused
> variable instead of MMU_NOTIFY_CLEAR being undefined :/
>
> I think this should be done so that anybody using
> mmu_notifier_range_init() doesn't need to worry about the implications of
> *any* unused formal parameter as a result of how the #define is formed:

Your patch below is more or less what I tried at first, and that resulted
in another build failure for

mm/hugetlb.c: mmu_notifier_range_init(&range, mm, start, end,
MMU_NOTIFY_CLEAR);
mm/hugetlb.c- adjust_range_if_pmd_sharing_possible(vma,
&range.start, &range.end);

where range.end refers to a nonexisting member of range.

Arnd

\
 
 \ /
  Last update: 2018-12-11 22:53    [W:0.075 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site