lkml.org 
[lkml]   [2018]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/3] ACPI: Allow PCI to be disabled for reboot
From
Date
On 12/11/2018 5:12 AM, Rafael J. Wysocki wrote:
> On Sat, Dec 8, 2018 at 10:47 PM Sinan Kaya <okaya@kernel.org> wrote:
>>
>> Make PCI reboot conditional on PCI support being present on the kernel
>> configuration.
>>
>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>
> Same comment as for patch [2/3]: make the subject say clearly that
> this is about CONFIG_PCI.

Sure

>> case ACPI_ADR_SPACE_PCI_CONFIG:
>> + {
>> +#ifdef CONFIG_PCI
>> + unsigned int devfn;
>> + struct pci_bus *bus0;
>> +
>> /* The reset register can only live on bus 0. */
>> bus0 = pci_find_bus(0, 0);
>> if (!bus0)
>> @@ -45,7 +48,10 @@ void acpi_reboot(void)
>> pci_bus_write_config_byte(bus0, devfn,
>> (rr->address & 0xffff), reset_value);
>> break;
>> -
>> +#else
>> + return;
>
> Why not "break"?
>

I struggled between break and return. Existing code seems to return on failure
when bus0 is NULL. I assumed it would be more logical to return as someone could
put some code after here that assumes everything is in order.

\
 
 \ /
  Last update: 2018-12-11 17:55    [W:4.290 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site