Messages in this thread | | | Subject | Re: [PATCH] thermal: st: fix Makefile typo | From | Daniel Lezcano <> | Date | Mon, 10 Dec 2018 23:01:05 +0100 |
| |
On 10/12/2018 22:57, Arnd Bergmann wrote: > When STM32_THERMAL is enabled, this overrides all previously > enabled files in the same directory, as seen from this link failure: > > ERROR: "st_thermal_pm_ops" [drivers/thermal/st/st_thermal_syscfg.ko] undefined! > ERROR: "st_thermal_register" [drivers/thermal/st/st_thermal_syscfg.ko] undefined! > ERROR: "st_thermal_unregister" [drivers/thermal/st/st_thermal_syscfg.ko] undefined! > > The correct syntax in Makefile requires using += instead of :=. > > Fixes: 1d6931556073 ("thermal: add stm32 thermal driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> --- > drivers/thermal/st/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/st/Makefile b/drivers/thermal/st/Makefile > index b2b9e9b96296..243ca7881b12 100644 > --- a/drivers/thermal/st/Makefile > +++ b/drivers/thermal/st/Makefile > @@ -1,4 +1,4 @@ > obj-$(CONFIG_ST_THERMAL) := st_thermal.o > obj-$(CONFIG_ST_THERMAL_SYSCFG) += st_thermal_syscfg.o > obj-$(CONFIG_ST_THERMAL_MEMMAP) += st_thermal_memmap.o > -obj-$(CONFIG_STM32_THERMAL) := stm_thermal.o > \ No newline at end of file > +obj-$(CONFIG_STM32_THERMAL) += stm_thermal.o >
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |