Messages in this thread | | | Date | Mon, 10 Dec 2018 16:10:50 -0800 | From | Bjorn Andersson <> | Subject | Re: [PATCH v2 1/6] misc: dt-bindings: Add Qualcomm Fastrpc bindings |
| |
On Mon 10 Dec 03:17 PST 2018, Srinivas Kandagatla wrote: > On 07/12/18 18:23, Mark Rutland wrote: > > On Fri, Dec 07, 2018 at 04:35:08PM +0000, Srinivas Kandagatla wrote: > > > diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt b/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt [..] > > > +- reg > > > + Usage: required > > > + Value type: <u32> > > > + Definition: DSP Processor ID. > > > + Possible values are : > > > + 0 - ADSP > > > + 1 - MDSP > > > + 2 - SDSP > > > + 3 - CDSP > > > > Why is this in a reg? > > This is to identify which type of dsp(Audio/Modem/Sensor/Compute) it is, > This information is used to create device nodes for user-space access. >
But it does not represent FastRPC's address on the rpmsg bus. How about replacing it with a "label" (or "qcom,domain" perhaps?) of type string?
Regards, Bjorn
| |