Messages in this thread | ![/](/images/icornerl.gif) | | From | Doug Anderson <> | Date | Mon, 10 Dec 2018 15:56:48 -0800 | Subject | Re: [PATCH 1/3] dt-bindings: soc: qcom: Add AOSS QMP binding |
| |
Hi,
On Mon, Nov 12, 2018 at 12:02 AM Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > + aoss_qmp: qmp@c300000 { > + compatible = "qcom,sdm845-aoss-qmp"; > + reg = <0x0c300000 0x100000>;
drive-by nit: s/0x0c300000/0xc300000
...another random suggestion is that I think Rob H. has been requesting that examples have the #include in them...
-Doug
| ![\](/images/icornerr.gif) |