Messages in this thread | | | Date | Thu, 8 Nov 2018 11:37:43 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH] sched/fair: make some function static |
| |
On Thu, Nov 08, 2018 at 01:54:12PM +0800, Yi Wang wrote: > Make some function static as they are not used outside of fair.c. > > This fixes the following warning when building with 'W=1': > > kernel/sched/fair.c:2439:6: warning: no previous prototype for ‘task_numa_work’ [-Wmissing-prototypes] > kernel/sched/fair.c:2584:6: warning: no previous prototype for ‘task_tick_numa’ [-Wmissing-prototypes] > kernel/sched/fair.c:3548:6: warning: no previous prototype for ‘sync_entity_load_avg’ [-Wmissing-prototypes] > kernel/sched/fair.c:3561:6: warning: no previous prototype for ‘remove_entity_load_avg’ [-Wmissing-prototypes] > > Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
I'm not sure why; but when I apply I get:
$ quilt push Applying patch patches/yi_wang-sched_fair-make_some_function_static.patch patching file kernel/sched/fair.c Hunk #1 FAILED at 2436. Hunk #2 FAILED at 2581. Hunk #3 FAILED at 3545. Hunk #4 FAILED at 3558. 4 out of 4 hunks FAILED -- rejects in file kernel/sched/fair.c Patch patches/yi_wang-sched_fair-make_some_function_static.patch does not apply (enforce with -f)D
| |