Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 8 Nov 2018 10:32:37 +0100 | From | Joerg Roedel <> | Subject | Re: [PATCH -next] iommu/amd: remove set but not used variable 'tag' |
| |
On Thu, Nov 08, 2018 at 06:12:40AM +0000, YueHaibing wrote: > - tag = event[1] & 0x03FF; > dev_err(dev, "INVALID_PPR_REQUEST device=%02x:%02x.%x pasid=0x%05x address=0x%016llx flags=0x%04x]\n", > PCI_BUS_NUM(devid), PCI_SLOT(devid), PCI_FUNC(devid), > pasid, address, flags);
This looks like tag was just missed in the error message. It is better to add it there instead of removing it.
Regards,
Joerg
| ![\](/images/icornerr.gif) |