Messages in this thread | | | From | Mathieu Malaterre <> | Date | Tue, 6 Nov 2018 21:35:35 +0100 | Subject | Re: [PATCH] kernel/watchdog: add missing prototypes for weak functions |
| |
ping ? On Wed, Jun 6, 2018 at 9:42 PM Mathieu Malaterre <malat@debian.org> wrote: > > In commit 73ce0511c436 ("kernel/watchdog.c: move hardlockup detector to > separate file") two new functions were added ‘watchdog_nmi_enable’ and > ‘watchdog_nmi_disable’ the functions were changed from static to weak. > In which case expose the function declarations in header file. > > Silence the following gcc warnings: > > kernel/watchdog.c:109:12: warning: no previous prototype for ‘watchdog_nmi_enable’ [-Wmissing-prototypes] > kernel/watchdog.c:115:13: warning: no previous prototype for ‘watchdog_nmi_disable’ [-Wmissing-prototypes] > > Cc: Babu Moger <babu.moger@oracle.com> > Signed-off-by: Mathieu Malaterre <malat@debian.org> > --- > include/linux/nmi.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/nmi.h b/include/linux/nmi.h > index b8d868d23e79..50d143995338 100644 > --- a/include/linux/nmi.h > +++ b/include/linux/nmi.h > @@ -113,6 +113,8 @@ static inline int hardlockup_detector_perf_init(void) { return 0; } > void watchdog_nmi_stop(void); > void watchdog_nmi_start(void); > int watchdog_nmi_probe(void); > +int watchdog_nmi_enable(unsigned int cpu); > +void watchdog_nmi_disable(unsigned int cpu); > > /** > * touch_nmi_watchdog - restart NMI watchdog timeout. > -- > 2.11.0 >
| |