lkml.org 
[lkml]   [2018]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND
Hi Otavio,

On Sun, Nov 25, 2018 at 6:18 PM Otavio Salvador <otavio@ossystems.com.br> wrote:
>
> The setting is removed when running a `savedefconfig` using the
> current setting set. It is being applied in preparation to some

"setting set" is a bit confusing.

> patches making changes to this defconfig.

It would be good to mention that CONFIG_ARM_UNWIND is still selected
automatically.

Otherwise it may give the impression that such functionality is being removed.

You could reword the commit log to something like this:

CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but it is
still selected by the Kconfig logic.
This is done in preparation to making further changes to this defconfig cleaner.

With the reworded commit log:

Reviewed-by: Fabio Estevam <festevam@gmail.com>

\
 
 \ /
  Last update: 2018-11-25 21:30    [W:0.052 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site