lkml.org 
[lkml]   [2018]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/8] socket: Disentangle SOCK_RCVTSTAMPNS from SOCK_RCVTSTAMP
From
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: Sun, 25 Nov 2018 09:18:55 -0500

> The existing logic is as is for a reason. There is no need to change
> it to satisfy the main purpose of your patchset?
>
> It is structured as one bit to test whether a timestamp is requested
> and another to select among two variants usec/nsec. Just add another
> layer of branching between new/old in cases where this distinction is
> needed.
>
> Please avoid code churn unless needed.

+1

\
 
 \ /
  Last update: 2018-11-25 19:21    [W:0.042 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site