lkml.org 
[lkml]   [2018]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 net-next] ptp: Fix pass zero to ERR_PTR() in ptp_clock_register
From
Date


On 2018/11/24 0:37, Richard Cochran wrote:
> On Fri, Nov 23, 2018 at 09:54:55AM +0800, YueHaibing wrote:
>> @@ -264,6 +266,7 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
>> pps.owner = info->owner;
>> ptp->pps_source = pps_register_source(&pps, PTP_PPS_DEFAULTS);
>> if (!ptp->pps_source) {
>> + err = -EINVAL;
>
> Bonus points: The function, pps_register_source(), keeps error codes
> in a local variable, but it does not make use of the code. There are
> only five callers of that function, and so it would be nice to let
> pps_register_source() return the error code.

Ok, I will post a new patch to do it.

>
> For the present patch:
>
> Acked-by: Richard Cochran <richardcochran@gmail.com>
>
>

\
 
 \ /
  Last update: 2018-11-26 11:21    [W:4.464 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site