lkml.org 
[lkml]   [2018]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/5] mm/memory_hotplug: Create add/del_device_memory functions
    > >  	/*
    > > * For device private memory we call add_pages() as we only need to
    > > * allocate and initialize struct page for the device memory. More-
    > > @@ -1096,20 +1100,17 @@ static int hmm_devmem_pages_create(struct hmm_devmem *devmem)
    > > * want the linear mapping and thus use arch_add_memory().
    > > */
    >
    > Some parts of this comment should be moved into add_device_memory now.
    > (e.g. we call add_pages() ...)

    I agree.

    > > +#ifdef CONFIG_ZONE_DEVICE
    > > +int del_device_memory(int nid, unsigned long start, unsigned long size,
    > > + struct vmem_altmap *altmap, bool mapping)
    > > +{
    > > + int ret;
    >
    > nit: personally I prefer short parameters last in the list.

    I do not have a strong opinion here.
    If people think that long parameters should be placed at the end because
    it improves readability, I am ok with moving them there.

    > Can you document for both functions that they should be called with the
    > memory hotplug lock in write?

    Sure, I will do that in the next version, once I get some more feedback.

    > Apart from that looks good to me.

    Thanks for reviewing it David ;-)!
    May I assume your Reviewed-by here (if the above comments are addressed)?

    Thanks
    --
    Oscar Salvador
    SUSE L3

    \
     
     \ /
      Last update: 2018-10-17 11:34    [W:4.024 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site