Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 12 Oct 2018 11:46:55 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v8 1/3] x86/boot: Add acpitb.c to parse acpi tables |
| |
On Fri, Oct 12, 2018 at 05:36:38PM +0800, Chao Fan wrote: > Prefer to compile out entire functions, rather than portions of functions or > portions of expressions. Rather than putting an ifdef in an expression, factor > out part or all of the expression into a separate helper function and apply the > conditional to that function. > > So I am puzzled. If my understanding is wrong, please let me know.
If you do it the way I suggested, you simply have one ifdeffery branch less. And ifdeffery is ugly. So less clutter. Also, this way you do compile out entire functions too.
HTH.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| ![\](/images/icornerr.gif) |