Messages in this thread | | | From | Trent Piepho <> | Subject | Re: [PATCH 2/2] dw: spi: add support for Alpine spi controller | Date | Wed, 10 Oct 2018 22:08:59 +0000 |
| |
On Wed, 2018-10-10 at 18:15 +0300, Talel Shenhar wrote: > Add support for a new devicetree compatible string called > 'al,alpine-apb-ssi', which is necessary for the Amazon Alpine spi > controller. 'al,alpine-dw-apb-ssi' is used in the dw spi driver if > specified in the devicetree. Otherwise, fall back to driver default > behavior, i.e. original dw IP hw driver behavior. > > Signed-off-by: Talel Shenhar <talel@amazon.com> > Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Shouldn't this be "amzn,alpine-apb-ssi"? The convention, and this IS documented, is to the use company's stock ticker symbol as the prefix, so as to have something grounded in the real world. I don't know of anyone else using a product line name as the company name in their dt bindings. Example, "snps,dw-apb-ssi", is named for Synopsis, not the Designware line.
| |