lkml.org 
[lkml]   [2018]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] mmc: tmio: move MFD variant reset to a platform hook

> +static void tmio_mmc_reset(struct tmio_mmc_host *host)
> +{
> + /* FIXME - should we set stop clock reg here */
> + sd_ctrl_write16(host, CTL_RESET_SD, 0x0000);
> + sd_ctrl_write16(host, CTL_RESET_SDIO, 0x0000);
> + usleep_range(10000, 11000);
> + sd_ctrl_write16(host, CTL_RESET_SD, 0x0001);
> + sd_ctrl_write16(host, CTL_RESET_SDIO, 0x0001);
> + usleep_range(10000, 11000);
> +
> + if (host->pdata->flags & TMIO_MMC_SDIO_IRQ) {
> + sd_ctrl_write16(host, CTL_SDIO_IRQ_MASK, host->sdio_irq_mask);
> + sd_ctrl_write16(host, CTL_TRANSACTION_CTL, 0x0001);
> + }
> +}

Yes, looks much safer now.

> + host->reset = tmio_mmc_reset;

So, you populate the new pointer here...

> + if (!_host->reset)
> + _host->reset = tmio_mmc_reset;

... and here. But it seems never used anywhere? Or am I missing
something?

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-10-10 01:48    [W:0.078 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site