Messages in this thread | | | Date | Tue, 9 Oct 2018 14:44:50 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v3 8/8] watchdog: stpmic1: add stpmic1 watchdog driver |
| |
On Tue, Oct 09, 2018 at 08:47:26AM +0800, kbuild test robot wrote: > Hi pascal, > > Thank you for the patch! Perhaps something to improve: >
[ ... ]
> 42 > 43 static int pmic_wdt_stop(struct watchdog_device *wdd) > 44 { > 45 struct stpmic1_wdt *wdt = watchdog_get_drvdata(wdd); > 46 > 47 return regmap_update_bits(wdt->pmic->regmap, > > 48 WCHDG_CR, WDT_START_MASK, ~WDT_START);
Maybe use
#define WDT_STOP 0
instead, or just write 0. ~WDT_START may be convenient but not really correct.
Guenter
| |