Messages in this thread | | | Date | Mon, 8 Jan 2018 18:14:28 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH RFC 1/4] x86/thread_info: add TIF_NOPTI to disable PTI per task |
| |
* Willy Tarreau <w@1wt.eu> wrote:
> On Mon, Jan 08, 2018 at 05:57:11PM +0100, Thomas Gleixner wrote: > > On Mon, 8 Jan 2018, Willy Tarreau wrote: > > > > > This flag indicates that the task will not use isolated page tables. > > > > > > Signed-off-by: Willy Tarreau <w@1wt.eu> > > > --- > > > arch/x86/include/asm/thread_info.h | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h > > > index 0022333..2f92cf1 100644 > > > --- a/arch/x86/include/asm/thread_info.h > > > +++ b/arch/x86/include/asm/thread_info.h > > > @@ -126,6 +126,14 @@ struct thread_info { > > > #define _TIF_X32 (1 << TIF_X32) > > > #define _TIF_FSCHECK (1 << TIF_FSCHECK) > > > > > > +/* The following flags only exist on x86-64. We can't use the shift anymore > > > > Please do not use this horrible comment syle > > You mean, the fact that there is no '/*' alone on the first line or > anything else ?
please use the customary (multi-line) comment style:
/* * Comment ..... * ...... goes here. */
specified in Documentation/CodingStyle.
Thanks,
Ingo
| |