lkml.org 
[lkml]   [2018]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/45] drivers: misc: remove duplicate includes
Hi Pravin,

On 2017-12-06 17:54, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl
> but
> they have been removed manually to avoid removing false positives.
>
> Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>
> ---
> drivers/misc/genwqe/card_base.c | 1 -
> drivers/misc/genwqe/card_ddcb.c | 1 -
> drivers/misc/genwqe/card_utils.c | 2 --
> 3 files changed, 4 deletions(-)
>
> diff --git a/drivers/misc/genwqe/card_base.c
> b/drivers/misc/genwqe/card_base.c
> index 4fd21e8..42bad26 100644
> --- a/drivers/misc/genwqe/card_base.c
> +++ b/drivers/misc/genwqe/card_base.c
> @@ -34,7 +34,6 @@
> #include <linux/wait.h>
> #include <linux/delay.h>
> #include <linux/dma-mapping.h>
> -#include <linux/module.h>
> #include <linux/notifier.h>
> #include <linux/device.h>
> #include <linux/log2.h>
> diff --git a/drivers/misc/genwqe/card_ddcb.c
> b/drivers/misc/genwqe/card_ddcb.c
> index ddfeefe..332a0d1 100644
> --- a/drivers/misc/genwqe/card_ddcb.c
> +++ b/drivers/misc/genwqe/card_ddcb.c
> @@ -34,7 +34,6 @@
> #include <linux/string.h>
> #include <linux/dma-mapping.h>
> #include <linux/delay.h>
> -#include <linux/module.h>
> #include <linux/interrupt.h>
> #include <linux/crc-itu-t.h>
>
> diff --git a/drivers/misc/genwqe/card_utils.c
> b/drivers/misc/genwqe/card_utils.c
> index 5c0d917..8fec04d 100644
> --- a/drivers/misc/genwqe/card_utils.c
> +++ b/drivers/misc/genwqe/card_utils.c
> @@ -32,11 +32,9 @@
> #include <linux/iommu.h>
> #include <linux/delay.h>
> #include <linux/pci.h>
> -#include <linux/dma-mapping.h>
> #include <linux/ctype.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> -#include <linux/delay.h>
> #include <asm/pgtable.h>
>
> #include "genwqe_driver.h"

Looks ok to me. Thanks for the contribution.

Regards

Frank

Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>

\
 
 \ /
  Last update: 2018-01-14 23:17    [W:0.059 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site