Messages in this thread Patch in this message | | | Subject | [PATCH 2/3] misc/ibmasm: Improve a size determination in ibmasm_init_one() | From | SF Markus Elfring <> | Date | Mon, 8 Jan 2018 14:09:32 +0100 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Mon, 8 Jan 2018 13:43:20 +0100
Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/misc/ibmasm/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/ibmasm/module.c b/drivers/misc/ibmasm/module.c index d22b3c428ca9..894397b1ee51 100644 --- a/drivers/misc/ibmasm/module.c +++ b/drivers/misc/ibmasm/module.c @@ -78,7 +78,7 @@ static int ibmasm_init_one(struct pci_dev *pdev, const struct pci_device_id *id) /* vnc client won't work without bus-mastering */ pci_set_master(pdev); - sp = kzalloc(sizeof(struct service_processor), GFP_KERNEL); + sp = kzalloc(sizeof(*sp), GFP_KERNEL); if (sp == NULL) { result = -ENOMEM; goto error_kmalloc; -- 2.15.1
| |