Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCH] usb: gadget: uvc:change the UVC_NUM_REQUESTS value | Date | Mon, 08 Jan 2018 13:54:15 +0200 |
| |
Hi,
Lipengcheng <lpc.li@hisilicon.com> writes: > The value is 4, it can cache four descriptors. When streaming_interval = 1, > it can tolerate 500us. Some busy scenes, it may be more than 500us because > cpu scheduling is not timely. There will have some problems. It is better > set to eight. > > Signed-off-by: Pengcheng Li <lpc.li@hisilicon.com> > --- > drivers/usb/gadget/function/uvc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/function/uvc.h b/drivers/usb/gadget/function/uvc.h > index a64e07e..901487e 100644 > --- a/drivers/usb/gadget/function/uvc.h > +++ b/drivers/usb/gadget/function/uvc.h > @@ -90,7 +90,7 @@ extern unsigned int uvc_gadget_trace_param; > * Driver specific constants > */ > > -#define UVC_NUM_REQUESTS 4 > +#define UVC_NUM_REQUESTS 8
if you want to be taken seriously, the bare minimum you can do is to use scripts/get_maintainer.pl to help with a proper Cc list:
$ scripts/get_maintainer.pl -f drivers/usb/gadget/function/uvc.h Laurent Pinchart <laurent.pinchart@ideasonboard.com> (maintainer:USB WEBCAM GADGET) Felipe Balbi <balbi@kernel.org> (maintainer:USB GADGET/PERIPHERAL SUBSYSTEM) Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:USB SUBSYSTEM) linux-usb@vger.kernel.org (open list:USB WEBCAM GADGET) linux-kernel@vger.kernel.org (open list)
Laurent, what do you think about this?
-- balbi [unhandled content-type:application/pgp-signature]
| |