Messages in this thread | | | Date | Mon, 8 Jan 2018 13:58:06 +1100 (AEDT) | From | Finn Thain <> | Subject | Re: [PATCH v4 00/14] Modernization and fixes for NuBus subsystem |
| |
On Sun, 7 Jan 2018, Geert Uytterhoeven wrote:
> it does complain when using spaces only ("please, no spaces at the > _start_ of a line"). >
Checkpatch accepts this tab:
int map(struct mm_id * mm_idp, unsigned long virt, unsigned long len, int prot, int phys_fd, unsigned long long offset, int done, void **data)
and this one:
int unlz4(unsigned char *inbuf, long len, long (*fill)(void*, unsigned long),
and this combination of tabs and spaces:
void sort(void *base, size_t num, size_t size, int (*cmp_func)(const void *, const void *),
We have no declarations of identifiers shorter than "map" in the kernel, as yet, as luck would have it. This would be a violation:
int eq(long __and_complicated_type parameter_a, long __and_complicated_type parameter_b,
Unfortunately I don't have a better style checker to offer. So I won't go on about simplistic rules or the effect of excess tabs on refactoring, readability and re-usability. Suffice it to say that there seems to be room for maintainer discretion.
> Do you want to assume maintainership for nubus? >
I do intend to take responsibility for any regressions so I might as well assume maintainership too. If future patches continue to go through your tree, and given there are so few committers, it's just a formality, I think.
> check your TABs and spaces again >
Will comply.
Thanks.
--
| |