Messages in this thread | | | Subject | Re: [PATCH] mtd/nand/atmel: Delete an error message for a failed memory allocation in two functions | From | "Yang, Wenyou" <> | Date | Mon, 8 Jan 2018 08:58:21 +0800 |
| |
On 2018/1/6 4:55, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 5 Jan 2018 21:45:04 +0100 > > Omit an extra message for a memory allocation failure in these functions. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > ---
Acked-by: Wenyou Yang <wenyou.yang@microchip.com> > drivers/mtd/nand/atmel/nand-controller.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c > index 90a71a56bc23..a41b999229c9 100644 > --- a/drivers/mtd/nand/atmel/nand-controller.c > +++ b/drivers/mtd/nand/atmel/nand-controller.c > @@ -1612,10 +1612,8 @@ static int atmel_nand_register(struct atmel_nand *nand) > mtd->name = devm_kasprintf(nc->dev, GFP_KERNEL, > "%s:nand.%d", dev_name(nc->dev), > nand->cs[0].id); > - if (!mtd->name) { > - dev_err(nc->dev, "Failed to allocate mtd->name\n"); > + if (!mtd->name) > return -ENOMEM; > - } > } > > ret = nand_scan_tail(mtd); > @@ -1654,10 +1652,8 @@ static struct atmel_nand *atmel_nand_create(struct atmel_nand_controller *nc, > nand = devm_kzalloc(nc->dev, > sizeof(*nand) + (numcs * sizeof(*nand->cs)), > GFP_KERNEL); > - if (!nand) { > - dev_err(nc->dev, "Failed to allocate NAND object\n"); > + if (!nand) > return ERR_PTR(-ENOMEM); > - } > > nand->numcs = numcs; >
Best Regards, Wenyou Yang
| |