lkml.org 
[lkml]   [2018]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/3] regcache: flat: Un-inline index lookup from cache access
    Date
    This makes the code slightly more readable and allows for cleaner
    addition of functionality in later patches.

    Signed-off-by: Andrew F. Davis <afd@ti.com>
    ---
    drivers/base/regmap/regcache-flat.c | 15 ++++++++++-----
    1 file changed, 10 insertions(+), 5 deletions(-)

    diff --git a/drivers/base/regmap/regcache-flat.c b/drivers/base/regmap/regcache-flat.c
    index 2ea5fc84a374..99a7792210b3 100644
    --- a/drivers/base/regmap/regcache-flat.c
    +++ b/drivers/base/regmap/regcache-flat.c
    @@ -37,9 +37,12 @@ static int regcache_flat_init(struct regmap *map)

    cache = map->cache;

    - for (i = 0; i < map->num_reg_defaults; i++)
    - cache[regcache_flat_get_index(map, map->reg_defaults[i].reg)] =
    - map->reg_defaults[i].def;
    + for (i = 0; i < map->num_reg_defaults; i++) {
    + unsigned int reg = map->reg_defaults[i].reg;
    + unsigned int index = regcache_flat_get_index(map, reg);
    +
    + cache[index] = map->reg_defaults[i].def;
    + }

    return 0;
    }
    @@ -56,8 +59,9 @@ static int regcache_flat_read(struct regmap *map,
    unsigned int reg, unsigned int *value)
    {
    unsigned int *cache = map->cache;
    + unsigned int index = regcache_flat_get_index(map, reg);

    - *value = cache[regcache_flat_get_index(map, reg)];
    + *value = cache[index];

    return 0;
    }
    @@ -66,8 +70,9 @@ static int regcache_flat_write(struct regmap *map, unsigned int reg,
    unsigned int value)
    {
    unsigned int *cache = map->cache;
    + unsigned int index = regcache_flat_get_index(map, reg);

    - cache[regcache_flat_get_index(map, reg)] = value;
    + cache[index] = value;

    return 0;
    }
    --
    2.15.1
    \
     
     \ /
      Last update: 2018-01-14 23:16    [W:2.220 / U:0.564 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site