Messages in this thread | | | Subject | Re: [PATCH 1/5] iio: buffer: use permission specific variants of DEVICE_ATTR | From | Lars-Peter Clausen <> | Date | Sat, 6 Jan 2018 13:50:28 +0100 |
| |
On 01/06/2018 01:35 PM, Jonathan Cameron wrote: > On Thu, 4 Jan 2018 20:07:14 +0530 > Aishwarya Pant <aishpant@gmail.com> wrote: > >> This is a clean-up patch which replaces DEVICE_ATTR macro with the file >> permission specific DEVICE_ATTR_{RO/WO/RW} macros for compaction and >> readability. Done using coccinelle. > > Hmm. I'll be honest, I personally really dislike these macros. > They absolutely don't help with readability because they obscure > the connection between the attributes being created and their callbacks. > Short is not the same as more readable.
FWIW fully agreed.
| |