lkml.org 
[lkml]   [2018]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Staging: irda: Prefer 'unsigned int' to bare use of 'unsigned'
Hi,

Did you read this?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/irda/TODO


Thanks,
Shyam


> This patch fixes the following checkpatch.pl issue at multiple lines:
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Sumit Pundir <pundirsumit11@gmail.com>
> ---
> drivers/staging/irda/drivers/act200l-sir.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/irda/drivers/act200l-sir.c b/drivers/staging/irda/drivers/act200l-sir.c
> index e891751..62a02e5 100644
> --- a/drivers/staging/irda/drivers/act200l-sir.c
> +++ b/drivers/staging/irda/drivers/act200l-sir.c
> @@ -29,7 +29,7 @@
> static int act200l_reset(struct sir_dev *dev);
> static int act200l_open(struct sir_dev *dev);
> static int act200l_close(struct sir_dev *dev);
> -static int act200l_change_speed(struct sir_dev *dev, unsigned speed);
> +static int act200l_change_speed(struct sir_dev *dev, unsigned int speed);
>
> /* Regsiter 0: Control register #1 */
> #define ACT200L_REG0 0x00
> @@ -134,7 +134,7 @@ static int act200l_close(struct sir_dev *dev)
> * Set the speed for the ACTiSYS ACT-IR200L type dongle.
> *
> */
> -static int act200l_change_speed(struct sir_dev *dev, unsigned speed)
> +static int act200l_change_speed(struct sir_dev *dev, unsigned int speed)
> {
> u8 control[3];
> int ret = 0;
> @@ -191,8 +191,8 @@ static int act200l_change_speed(struct sir_dev *dev, unsigned speed)
>
> static int act200l_reset(struct sir_dev *dev)
> {
> - unsigned state = dev->fsm.substate;
> - unsigned delay = 0;
> + unsigned int state = dev->fsm.substate;
> + unsigned int delay = 0;
> static const u8 control[9] = {
> ACT200L_REG15,
> ACT200L_REG13 | ACT200L_SHDW,
> --
> 2.7.4
>

\
 
 \ /
  Last update: 2018-01-05 11:44    [W:0.033 / U:2.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site