Messages in this thread | | | From | Logan Gunthorpe <> | Date | Thu, 4 Jan 2018 17:20:19 -0700 | Subject | Re: [PATCH 01/12] pci-p2p: Support peer to peer memory |
| |
On 04/01/18 02:59 PM, Bjorn Helgaas wrote: > On Thu, Jan 04, 2018 at 12:01:26PM -0700, Logan Gunthorpe wrote: >> Some PCI devices may have memory mapped in a BAR space that's >> intended for use in Peer-to-Peer transactions. In order to enable >> such transactions the memory must be registered with ZONE_DEVICE pages >> so it can be used by DMA interfaces in existing drivers. >> ... > >> + * pci_p2pmem_alloc_sgl - allocate p2p memory in an sgl >> + * @pdev: the device to allocate memory from >> + * @sgl: the allocated sgl >> + * @nents: the number of sgs in the list >> + * @length: number of bytes to allocate > > Your later patches use "SGL" in English text. If that's the conventional > capitalization, please use it here, too. >
I'm not sure there is a convention. scatterlist.h uses 'sglist' and 'scatterlist' so I'll just change my comments to use the latter.
Logan
| |