lkml.org 
[lkml]   [2018]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v5 03/20] firmware: arm_scmi: add basic driver infrastructure for SCMI
    Hi Sudeep,

    thank you for working on this.

    On Tue, Jan 2, 2018 at 2:42 PM, Sudeep Holla <sudeep.holla@arm.com> wrote:

    [...]

    > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
    > new file mode 100644
    > index 000000000000..58d8f88893e6
    > --- /dev/null
    > +++ b/drivers/firmware/arm_scmi/driver.c

    [..]

    > + * Return: 0 is successfully released
    > + * if null was passed, it returns -EINVAL;
    > + */
    > +int scmi_handle_put(const struct scmi_handle *handle)
    > +{
    > + struct scmi_info *info;
    > +
    > + if (!handle)
    > + return -EINVAL;
    > +
    > + info = handle_to_scmi_info(handle);
    > + mutex_lock(&scmi_list_mutex);
    > + if (!WARN_ON(!info->users))
    > + info->users--;
    > + mutex_unlock(&scmi_list_mutex);
    > +
    > + return 0;
    > +}
    > +
    > +static const struct scmi_desc scmi_generic_desc = {
    > + .max_rx_timeout_ms = 30, /* we may increase this if required */

    What are your thoughts about making it a module parameter?

    IIRC, this may required to be increased when someone uses debugging
    version of firmware, for example.
    In such case someone might need to recompile the kernel in order to
    boot with enabled and initialized scmi.

    Also, there can be a chance that another transport will be used that
    will require larger than 5 * 30 ms delay (such kind of transport can
    be kinda useless, I know, but can help with development).

    With module parameter you can still boot passing the larger timeout
    parameter to the module from cmdline.

    > + .max_msg = 20, /* Limited by MBOX_TX_QUEUE_LEN */
    > + .max_msg_size = 128,
    > +};

    Best regards,
    Alexey

    \
     
     \ /
      Last update: 2018-01-04 20:22    [W:4.055 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site