lkml.org 
[lkml]   [2018]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 04/16] iio: adc: sun4i-gpadc-iio: rework: sampling start/end code readout reg
    From
    Date


    On 31.01.2018 18:51, Quentin Schulz wrote:
    > Hi Philipp,
    >
    > On Mon, Jan 29, 2018 at 12:29:07AM +0100, Philipp Rossak wrote:
    >> For adding newer sensor some basic rework of the code is necessary.
    >>
    >> This commit reworks the code and allows the sampling start/end code and
    >> the position of value readout register to be altered. Later the start/end
    >> functions will be used to configure the ths and start/stop the
    >> sampling.
    >>
    >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
    >> Signed-off-by: Philipp Rossak <embed3d@gmail.com>
    >> ---
    >> drivers/iio/adc/sun4i-gpadc-iio.c | 44 ++++++++++++++++++++++++++++++++++-----
    >> 1 file changed, 39 insertions(+), 5 deletions(-)
    >>
    >> diff --git a/drivers/iio/adc/sun4i-gpadc-iio.c b/drivers/iio/adc/sun4i-gpadc-iio.c
    >> index 03804ff9c006..db57d9fffe48 100644
    >> --- a/drivers/iio/adc/sun4i-gpadc-iio.c
    >> +++ b/drivers/iio/adc/sun4i-gpadc-iio.c
    >> @@ -49,6 +49,15 @@ static unsigned int sun6i_gpadc_chan_select(unsigned int chan)
    >> return SUN6I_GPADC_CTRL1_ADC_CHAN_SELECT(chan);
    >> }
    >>
    >> +struct sun4i_gpadc_iio;
    >> +
    >> +/*
    >> + * Prototypes for these functions, which enable these functions to be
    >> + * referenced in gpadc_data structures.
    >> + */
    >
    > Comment not needed.
    >
    >> +static int sun4i_gpadc_sample_start(struct sun4i_gpadc_iio *info);
    >> +static int sun4i_gpadc_sample_end(struct sun4i_gpadc_iio *info);
    >> +
    >> struct gpadc_data {
    >> int temp_offset;
    >> int temp_scale;
    >> @@ -56,6 +65,9 @@ struct gpadc_data {
    >> unsigned int tp_adc_select;
    >> unsigned int (*adc_chan_select)(unsigned int chan);
    >> unsigned int adc_chan_mask;
    >> + unsigned int temp_data;
    >
    > Does not really have anything to do with sample_start/end. I would have
    > made a different commit for it.
    >
    > Otherwise,
    > Reviewed-by: Quentin Schulz <quentin.schulz@free-electrons.com>
    >
    > Quentin
    >

    Ok I will split this.

    Thanks,
    Philipp

    \
     
     \ /
      Last update: 2018-01-31 19:36    [W:4.051 / U:0.608 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site